Mirrors/CliFx
1
0
Fork 0
mirror of https://github.com/Tyrrrz/CliFx.git synced 2025-10-25 15:19:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add negative tests for CommandOptionInputConverter

Browse Source
This commit is contained in:
Alexey Golub
2019-08-20 12:27:11 +03:00
parent 89cc3c8785
commit 256b693466
4 changed files with 47 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
CliFx.Tests/CommandOptionInputConverterTests.Types.cs
View File

@@ -46,4 +46,18 @@ namespace CliFx.Tests
new TestStringParseableWithFormatProvider(value + " " + formatProvider);
}
}
// Negative
public partial class CommandOptionInputConverterTests
{
private class NonStringParseable
{
public int Value { get; }
public NonStringParseable(int value)
{
Value = value;
}
}
}
}

30
CliFx.Tests/CommandOptionInputConverterTests.cs
View File

@@ -2,6 +2,7 @@
using System.Collections;
using System.Collections.Generic;
using System.Globalization;
using CliFx.Exceptions;
using CliFx.Models;
using CliFx.Services;
using FluentAssertions;
@@ -261,19 +262,44 @@ namespace CliFx.Tests
);
}
private static IEnumerable<TestCaseData> GetTestCases_ConvertOptionInput_Negative()
{
yield return new TestCaseData(
new CommandOptionInput("option", "1234.5"),
typeof(int)
);
yield return new TestCaseData(
new CommandOptionInput("option", "123"),
typeof(NonStringParseable)
);
}
[Test]
[TestCaseSource(nameof(GetTestCases_ConvertOptionInput))]
public void ConvertOptionInput_Test(CommandOptionInput optionInput, Type targetType, object expectedConvertedValue)
{
// Arrange
var converter = new CommandOptionInputConverter();
var commandOptionInputConverter = new CommandOptionInputConverter();
// Act
var convertedValue = converter.ConvertOptionInput(optionInput, targetType);
var convertedValue = commandOptionInputConverter.ConvertOptionInput(optionInput, targetType);
// Assert
convertedValue.Should().BeEquivalentTo(expectedConvertedValue);
convertedValue?.Should().BeAssignableTo(targetType);
}
[Test]
[TestCaseSource(nameof(GetTestCases_ConvertOptionInput_Negative))]
public void ConvertOptionInput_Negative_Test(CommandOptionInput optionInput, Type targetType)
{
// Arrange
var commandOptionInputConverter = new CommandOptionInputConverter();
// Act & Assert
commandOptionInputConverter.Invoking(c => c.ConvertOptionInput(optionInput, targetType)).Should()
.ThrowExactly<InvalidCommandOptionInputException>();
}
}
}

5
CliFx.Tests/CommandSchemaResolverTests.Commands.cs
View File

@@ -10,8 +10,6 @@ namespace CliFx.Tests
[Command("cmd", Description = "NormalCommand1 description.")]
private class NormalCommand1 : ICommand
{
public string NotAnOption { get; set; }
[CommandOption("option-a", 'a')]
public int OptionA { get; set; }
@@ -30,10 +28,13 @@ namespace CliFx.Tests
[CommandOption("option-d", 'd')]
public DateTimeOffset OptionD { get; set; }
public string NotAnOption { get; set; }
public Task ExecuteAsync(IConsole console) => Task.CompletedTask;
}
}
// Negative
public partial class CommandSchemaResolverTests
{
[Command("conflict")]

3
CliFx.Tests/CommandSchemaResolverTests.cs
View File

@@ -87,7 +87,8 @@ namespace CliFx.Tests
var commandSchemaResolver = new CommandSchemaResolver();
// Act & Assert
commandSchemaResolver.Invoking(r => r.GetCommandSchemas(commandTypes)).Should().ThrowExactly<InvalidCommandSchemaException>();
commandSchemaResolver.Invoking(r => r.GetCommandSchemas(commandTypes)).Should()
.ThrowExactly<InvalidCommandSchemaException>();
}
}
}