Mirrors/CliFx
1
0
Fork 0
mirror of https://github.com/Tyrrrz/CliFx.git synced 2025-10-25 15:19:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't write default value in help text for types that don't override ToString()

Browse Source
This commit is contained in:
Tyrrrz
2021-04-16 23:28:39 +03:00
parent 4835e64388
commit fc5af8dbbc
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CliFx/Formatting/HelpConsoleFormatter.cs
View File

@@ -321,6 +321,8 @@ namespace CliFx.Formatting
Write(element.ToString(CultureInfo.InvariantCulture));
Write(ConsoleColor.DarkGray, '"');
}
Write('.');
}
}
else
@@ -332,10 +334,9 @@ namespace CliFx.Formatting
Write(ConsoleColor.DarkGray, '"');
Write(defaultValue.ToString(CultureInfo.InvariantCulture));
Write(ConsoleColor.DarkGray, '"');
Write('.');
}
}
Write('.');
}
}

8
CliFx/Utils/Extensions/TypeExtensions.cs
View File

@@ -54,9 +54,11 @@ namespace CliFx.Utils.Extensions
return array;
}
public static bool IsToStringOverriden(this Type type) =>
type.GetMethod(nameof(ToString), Type.EmptyTypes) !=
typeof(object).GetMethod(nameof(ToString), Type.EmptyTypes);
public static bool IsToStringOverriden(this Type type)
{
var toStringMethod = type.GetMethod(nameof(ToString), Type.EmptyTypes);
return toStringMethod?.GetBaseDefinition()?.DeclaringType != toStringMethod?.DeclaringType;
}
// Types supported by `Convert.ChangeType(...)`
private static readonly HashSet<Type> ConvertibleTypes = new()