From ca096e267e5c56e6bac1f13833f8da3c5c5c701a Mon Sep 17 00:00:00 2001
From: Srihari Sridharan <srihari.sridharan.r@gmail.com>
Date: Sat, 23 May 2026 18:47:24 +0530
Subject: [PATCH] Fixed code analysis suggestions.

---
 .../OnlineShop.ServiceDefaults/Extensions.cs         | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/BaselineApp/OnlineShop/OnlineShop.ServiceDefaults/Extensions.cs b/BaselineApp/OnlineShop/OnlineShop.ServiceDefaults/Extensions.cs
index cb67bfb..fb02fe2 100644
--- a/BaselineApp/OnlineShop/OnlineShop.ServiceDefaults/Extensions.cs
+++ b/BaselineApp/OnlineShop/OnlineShop.ServiceDefaults/Extensions.cs
@@ -44,7 +44,7 @@ public static class Extensions
         return builder;
     }
 
-    public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
+    private static void ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
     {
         builder.Logging.AddOpenTelemetry(logging =>
         {
@@ -74,11 +74,9 @@ public static class Extensions
             });
 
         builder.AddOpenTelemetryExporters();
-
-        return builder;
     }
 
-    private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
+    private static void AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
     {
         var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
 
@@ -93,17 +91,13 @@ public static class Extensions
         //    builder.Services.AddOpenTelemetry()
         //       .UseAzureMonitor();
         //}
-
-        return builder;
     }
 
-    public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
+    private static void AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
     {
         builder.Services.AddHealthChecks()
             // Add a default liveness check to ensure app is responsive
             .AddCheck("self", () => HealthCheckResult.Healthy(), ["live"]);
-
-        return builder;
     }
 
     public static WebApplication MapDefaultEndpoints(this WebApplication app)