From 80071e263eefdcc683a6c844aa2f33819e5a2fd6 Mon Sep 17 00:00:00 2001
From: Marco Minerva <marco.minerva@gmail.com>
Date: Fri, 10 Jan 2025 10:43:14 +0100
Subject: [PATCH] Update comments and package version

Enhanced comments in ChatService for token counting clarity.
Updated Microsoft.SemanticKernel to 1.33.0 in SqlDatabaseVectorSearch.csproj.
Added possible values comment for ModelId in appsettings.json.
---
 SqlDatabaseVectorSearch/Services/ChatService.cs        | 3 ++-
 SqlDatabaseVectorSearch/SqlDatabaseVectorSearch.csproj | 2 +-
 SqlDatabaseVectorSearch/appsettings.json               | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/SqlDatabaseVectorSearch/Services/ChatService.cs b/SqlDatabaseVectorSearch/Services/ChatService.cs
index dce855c..fc5cd36 100644
--- a/SqlDatabaseVectorSearch/Services/ChatService.cs
+++ b/SqlDatabaseVectorSearch/Services/ChatService.cs
@@ -53,7 +53,8 @@ public class ChatService(IChatCompletionService chatCompletionService, Tokenizer
             """);
 
         var tokensAvailable = appSettings.MaxInputTokens
-                              - tokenizerService.CountTokens(chat[0].ToString()) - tokenizerService.CountTokens(prompt.ToString())
+                              - tokenizerService.CountTokens(chat[0].ToString())    // System prompt.
+                              - tokenizerService.CountTokens(prompt.ToString()) // Initial user prompt.
                               - appSettings.MaxOutputTokens;    // To ensure there is enough space for the answer.
 
         foreach (var chunk in chunks)
diff --git a/SqlDatabaseVectorSearch/SqlDatabaseVectorSearch.csproj b/SqlDatabaseVectorSearch/SqlDatabaseVectorSearch.csproj
index eece150..b4a910f 100644
--- a/SqlDatabaseVectorSearch/SqlDatabaseVectorSearch.csproj
+++ b/SqlDatabaseVectorSearch/SqlDatabaseVectorSearch.csproj
@@ -16,7 +16,7 @@
         <PackageReference Include="Microsoft.ML.Tokenizers" Version="1.0.0" />
         <PackageReference Include="Microsoft.ML.Tokenizers.Data.Cl100kBase" Version="1.0.0" />
         <PackageReference Include="Microsoft.ML.Tokenizers.Data.O200kBase" Version="1.0.0" />
-        <PackageReference Include="Microsoft.SemanticKernel" Version="1.32.0" />
+        <PackageReference Include="Microsoft.SemanticKernel" Version="1.33.0" />
         <PackageReference Include="MinimalHelpers.OpenApi" Version="2.1.2" />
         <PackageReference Include="PdfPig" Version="0.1.9" />
         <PackageReference Include="Swashbuckle.AspNetCore.SwaggerUI" Version="7.2.0" />
diff --git a/SqlDatabaseVectorSearch/appsettings.json b/SqlDatabaseVectorSearch/appsettings.json
index 1b3beb0..7c0435b 100644
--- a/SqlDatabaseVectorSearch/appsettings.json
+++ b/SqlDatabaseVectorSearch/appsettings.json
@@ -7,7 +7,7 @@
             "Endpoint": "",
             "Deployment": "",
             "ApiKey": "",
-            "ModelId": ""
+            "ModelId": "" // o1, gpt-4o, gpt-4, gpt-3.5 
         },
         "Embedding": {
             "Endpoint": "",