NodeJSElectron: remove eslint & add CI type check

.github/workflows/build.yml

@@ -175,16 +175,21 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Check lib-nodejs
-        working-directory: src/lib-nodejs
-        run: |
-          npm install
-          npm run build
       - name: Check lib-rust
         run: cargo check -p velopack -F async,delta
       - name: Check RustIced Sample
         working-directory: samples/RustIced
         run: cargo check
+      - name: Check lib-nodejs
+        working-directory: src/lib-nodejs
+        run: |
+          npm install
+          npm run build
+      - name: Check NodeJSElectron Sample
+        working-directory: samples/NodeJSElectron
+        run: |
+          npm install
+          npm run typecheck
       - uses: caesay/wait-artifact-action@494939e840383463b1686ce3624a8aab059c2c8b
         with:
           token: ${{ secrets.GITHUB_TOKEN }}

samples/NodeJSElectron/.eslintrc.json

@@ -1,16 +0,0 @@
-{
-  "env": {
-    "browser": true,
-    "es6": true,
-    "node": true
-  },
-  "extends": [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:import/recommended",
-    "plugin:import/electron",
-    "plugin:import/typescript"
-  ],
-  "parser": "@typescript-eslint/parser"
-}

samples/NodeJSElectron/package.json

@@ -10,7 +10,7 @@
     "package": "electron-forge package",
     "make": "electron-forge make",
     "publish": "electron-forge publish",
-    "lint": "eslint --ext .ts,.tsx ."
+    "typecheck": "tsc --noEmit"
   },
   "devDependencies": {
     "@electron-forge/cli": "^7.5.0",
@@ -21,21 +21,15 @@
     "@electron-forge/plugin-fuses": "^7.5.0",
     "@electron-forge/plugin-webpack": "^7.5.0",
     "@electron/fuses": "^1.8.0",
-    "@typescript-eslint/eslint-plugin": "^8.0.0",
-    "@typescript-eslint/parser": "^8.0.0",
     "@vercel/webpack-asset-relocator-loader": "^1.7.3",
     "css-loader": "^7.0.0",
     "electron": "33.0.0",
-    "eslint": "^9.0.0",
-    "eslint-plugin-import": "^2.31.0",
     "fork-ts-checker-webpack-plugin": "^9.0.0",
     "node-loader": "^2.0.0",
     "style-loader": "^4.0.0",
     "ts-loader": "^9.5.1",
     "ts-node": "^10.9.2",
-    "typescript": "~5.6.0"
-  },
-  "dependencies": {
+    "typescript": "~5.6.0",
     "velopack": "^0.0.755-g7719c71"
   }
 }

samples/readme.md

@@ -1,8 +1,8 @@
 # Velopack Samples
 
-- [**CSharpAvalonia**](CSharpAvalonia) - Velopack in a cross-platform app with [Avalonia](https://avaloniaui.net/).
-- [**CSharpUnityMono**](CSharpUnityMono) - Velopack with [Unity Game Engine](https://unity.com/) and Mono.
-- [**CSharpUno**](CSharpUno) - Velopack in a cross-platform app with [Uno Platform](https://github.com/unoplatform/uno).
-- [**CSharpWpf**](CSharpWpf) - Velopack with WPF on Windows.
-- [**NodeJSElectron**](NodeJSElectron) - Velopack in a cross-platform javascript app with [Electron](https://www.electronjs.org/).
-- [**RustIced**](RustIced) - Velopack in a cross-platform app with [Iced](https://github.com/iced-rs/iced).
+- [**C# / Avalonia**](CSharpAvalonia) - Velopack in a cross-platform app with [Avalonia](https://avaloniaui.net/).
+- [**C# / UnityMono**](CSharpUnityMono) - Velopack with [Unity Game Engine](https://unity.com/) and Mono.
+- [**C# / Uno**](CSharpUno) - Velopack in a cross-platform app with [Uno Platform](https://github.com/unoplatform/uno).
+- [**C# / Wpf**](CSharpWpf) - Velopack with WPF on Windows.
+- [**NodeJS / Electron**](NodeJSElectron) - Velopack in a cross-platform JavaScript app with [Electron](https://www.electronjs.org/).
+- [**Rust / Iced**](RustIced) - Velopack in a cross-platform app with [Iced](https://github.com/iced-rs/iced).