Mirrors/velopack
1
0
Fork 0
mirror of https://github.com/velopack/velopack.git synced 2025-10-25 15:19:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

python: Acquire GIL on each loop iteration when calling callback

Browse Source
This commit is contained in:
JessicaTegner
2025-08-23 14:27:16 +02:00
committed by Caelan
parent 84f5fb9d44
commit 935a36c6ea
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib-python/src/manager.rs
View File

@@ -63,15 +63,14 @@ impl UpdateManagerWrapper {
// Spawn a thread to handle progress updates // Spawn a thread to handle progress updates
let progress_thread = thread::spawn(move || { let progress_thread = thread::spawn(move || {
Python::with_gil(|py| {
while let Ok(progress) = receiver.recv() { while let Ok(progress) = receiver.recv() {
Python::with_gil(|py| {
if let Err(e) = callback.call1(py, (progress,)) { if let Err(e) = callback.call1(py, (progress,)) {
// Log error but continue - don't break the download // Log error but continue - don't break the download
eprintln!("Progress callback error: {}", e); eprintln!("Progress callback error: {}", e);
break;
}
} }
}); });
}
}); });
// Call download with the sender // Call download with the sender