From cf6898d4aa3d1075317e714a3d3fcf23da85c696 Mon Sep 17 00:00:00 2001 From: David Wilson Date: Wed, 5 Sep 2018 16:37:39 -0700 Subject: [PATCH] Add another assert to check prerelease comparisons across different versions --- test/ReleaseEntryTests.cs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/ReleaseEntryTests.cs b/test/ReleaseEntryTests.cs index 093a226d..6e7a12ff 100644 --- a/test/ReleaseEntryTests.cs +++ b/test/ReleaseEntryTests.cs @@ -264,9 +264,10 @@ namespace Squirrel.Tests.Core } [Fact] - public void SortDoubleDigitPrereleaseVersionsCorrectly() + public void WhenPreReleasesAreOutOfOrderSortByNumericSuffix() { var path = Path.GetTempFileName(); + var firstVersion = new SemanticVersion("1.1.9-beta105"); var secondVersion = new SemanticVersion("1.2.0-beta9"); var thirdVersion = new SemanticVersion("1.2.0-beta10"); var fourthVersion = new SemanticVersion("1.2.0-beta100"); @@ -275,6 +276,7 @@ namespace Squirrel.Tests.Core ReleaseEntry.ParseReleaseEntry(MockReleaseEntry("Espera-1.2.0-beta1-full.nupkg")), ReleaseEntry.ParseReleaseEntry(MockReleaseEntry("Espera-1.2.0-beta9-full.nupkg")), ReleaseEntry.ParseReleaseEntry(MockReleaseEntry("Espera-1.2.0-beta100-full.nupkg")), + ReleaseEntry.ParseReleaseEntry(MockReleaseEntry("Espera-1.1.9-beta105-full.nupkg")), ReleaseEntry.ParseReleaseEntry(MockReleaseEntry("Espera-1.2.0-beta10-full.nupkg")) }; @@ -282,9 +284,10 @@ namespace Squirrel.Tests.Core var releases = ReleaseEntry.ParseReleaseFile(File.ReadAllText(path)).ToArray(); - Assert.Equal(secondVersion, releases[1].Version); - Assert.Equal(thirdVersion, releases[2].Version); - Assert.Equal(fourthVersion, releases[3].Version); + Assert.Equal(firstVersion, releases[0].Version); + Assert.Equal(secondVersion, releases[2].Version); + Assert.Equal(thirdVersion, releases[3].Version); + Assert.Equal(fourthVersion, releases[4].Version); } [Fact]