From d05fdd607bae1189d7da7f493a8a623606eac300 Mon Sep 17 00:00:00 2001 From: Caelan Sayler Date: Sun, 18 May 2025 09:55:38 +0100 Subject: [PATCH] Fix build warning (tests do not enable nullable) --- src/lib-csharp/Sources/HttpClientFileDownloader.cs | 3 +-- test/Velopack.Tests/TestHelpers/FakeDownloader.cs | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib-csharp/Sources/HttpClientFileDownloader.cs b/src/lib-csharp/Sources/HttpClientFileDownloader.cs index 183b66cd..d0a2e7d0 100644 --- a/src/lib-csharp/Sources/HttpClientFileDownloader.cs +++ b/src/lib-csharp/Sources/HttpClientFileDownloader.cs @@ -9,7 +9,6 @@ using System.Threading.Tasks; namespace Velopack.Sources { - /// public class HttpClientFileDownloader : IFileDownloader { @@ -72,7 +71,7 @@ namespace Velopack.Sources { // https://stackoverflow.com/a/46497896/184746 // Get the http headers first to examine the content length - using var response = await client.GetAsync(requestUri, HttpCompletionOption.ResponseHeadersRead).ConfigureAwait(false); + using var response = await client.GetAsync(requestUri, HttpCompletionOption.ResponseHeadersRead, cancelToken).ConfigureAwait(false); response.EnsureSuccessStatusCode(); var contentLength = response.Content.Headers.ContentLength; diff --git a/test/Velopack.Tests/TestHelpers/FakeDownloader.cs b/test/Velopack.Tests/TestHelpers/FakeDownloader.cs index c929d8f6..ae603248 100644 --- a/test/Velopack.Tests/TestHelpers/FakeDownloader.cs +++ b/test/Velopack.Tests/TestHelpers/FakeDownloader.cs @@ -7,7 +7,7 @@ public class FakeDownloader : IFileDownloader { public string LastUrl { get; private set; } public string LastLocalFile { get; private set; } - public IDictionary? LastHeaders { get; private set; } + public IDictionary LastHeaders { get; private set; } = new Dictionary(); public byte[] MockedResponseBytes { get; set; } = []; public bool WriteMockLocalFile { get; set; } = false;