Mirrors/velopack
1
0
Fork 0
mirror of https://github.com/velopack/velopack.git synced 2025-10-25 15:19:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

More aggressively retry when creating stub executables, and do not stop the release if this fails.

Browse Source
This commit is contained in:
Caelan Sayler
2022-02-27 13:14:11 +00:00
parent 553548731a
commit dfc5b531fc
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/SquirrelCli/Program.cs
View File

@@ -247,8 +247,7 @@ namespace SquirrelCli
.Where(x => !x.Name.Contains("squirrel.exe", StringComparison.InvariantCultureIgnoreCase))
.Where(x => Utility.IsFileTopLevelInPackage(x.FullName, pkgPath))
.Where(x => Utility.ExecutableUsesWin32Subsystem(x.FullName))
.ForEachAsync(x => createExecutableStubForExe(x.FullName))
.Wait();
.ForEach(x => createExecutableStubForExe(x.FullName));
// sign all exe's in this package
new DirectoryInfo(pkgPath).GetAllFilesRecursively()
@@ -376,17 +375,23 @@ namespace SquirrelCli
}
}
static async Task createExecutableStubForExe(string exeToCopy)
static void createExecutableStubForExe(string exeToCopy)
{
try {
var target = Path.Combine(
Path.GetDirectoryName(exeToCopy),
Path.GetFileNameWithoutExtension(exeToCopy) + "_ExecutionStub.exe");
await Utility.CopyToAsync(HelperExe.StubExecutablePath, target);
Utility.Retry(() => File.Copy(HelperExe.StubExecutablePath, target, true));
Utility.Retry(() => {
using var writer = new Microsoft.NET.HostModel.ResourceUpdater(target, true);
writer.AddResourcesFromPEImage(exeToCopy);
writer.Update();
});
} catch (Exception ex) {
Log.ErrorException($"Error creating StubExecutable and copying resources for '{exeToCopy}'. This stub may or may not work properly.", ex);
}
}
}