Adding Windows releasify command tests

2025-10-25 15:19:22 +00:00 · 2022-09-23 23:00:59 -07:00
parent b1a758824a
commit ee2f0f368e
5 changed files with 353 additions and 6 deletions
--- a/test/Squirrel.CommandLine.Tests/OSX/PackCommandTests.cs
+++ b/test/Squirrel.CommandLine.Tests/OSX/PackCommandTests.cs
@@ -155,7 +155,7 @@ namespace Squirrel.CommandLine.Tests.OSX
            ParseResult parseResult = command.Parse(cli);

            Assert.Equal(1, parseResult.Errors.Count);
-            Assert.Equal($"{fileInfo.FullName} for --icon does not have an .ico extension", parseResult.Errors[0].Message);
+            Assert.Equal($"--icon does not have an .ico extension", parseResult.Errors[0].Message);
        }

        [Fact]
@@ -286,7 +286,7 @@ namespace Squirrel.CommandLine.Tests.OSX
            ParseResult parseResult = command.Parse(cli);

            Assert.Equal(1, parseResult.Errors.Count);
-            Assert.Equal($"{fileInfo.FullName} for --signEntitlements does not have an .entitlements extension", parseResult.Errors[0].Message);
+            Assert.Equal($"--signEntitlements does not have an .entitlements extension", parseResult.Errors[0].Message);
        }

        [Fact]
--- a/test/Squirrel.CommandLine.Tests/Windows/PackCommandTests.cs
+++ b/test/Squirrel.CommandLine.Tests/Windows/PackCommandTests.cs
@@ -260,7 +260,7 @@ namespace Squirrel.CommandLine.Tests.Windows
            ParseResult parseResult = command.Parse(cli);

            Assert.Equal(1, parseResult.Errors.Count);
-            Assert.Equal($"{fileInfo.FullName} for --icon does not have an .ico extension", parseResult.Errors[0].Message);
+            Assert.Equal($"--icon does not have an .ico extension", parseResult.Errors[0].Message);
        }

        [Fact]
@@ -310,7 +310,7 @@ namespace Squirrel.CommandLine.Tests.Windows
            ParseResult parseResult = command.Parse(cli);

            Assert.Equal(1, parseResult.Errors.Count);
-            Assert.Equal($"{fileInfo.FullName} for --appIcon does not have an .ico extension", parseResult.Errors[0].Message);
+            Assert.Equal($"--appIcon does not have an .ico extension", parseResult.Errors[0].Message);
        }

        [Fact]
--- a/test/Squirrel.CommandLine.Tests/Windows/ReleasifyCommandTests.cs
+++ b/test/Squirrel.CommandLine.Tests/Windows/ReleasifyCommandTests.cs
@@ -0,0 +1,347 @@
+using Xunit;
+using Squirrel.CommandLine.Windows;
+using System.CommandLine;
+using System.CommandLine.Parsing;
+
+namespace Squirrel.CommandLine.Tests.Windows
+{
+    public class ReleasifyCommandTests : TempFileTestBase
+    {
+        [Fact]
+        public void Command_WithValidRequiredArguments_Parses()
+        {
+            FileInfo package = CreateTempFile(name:Path.ChangeExtension(Path.GetRandomFileName(), ".nupkg"));
+            var command = new ReleasifyCommand();
+
+            ParseResult parseResult = command.Parse($"--package \"{package.FullName}\"");
+
+            Assert.Empty(parseResult.Errors);
+            Assert.Equal(package.FullName, parseResult.GetValueForOption(command.Package)?.FullName);
+        }
+
+        [Fact]
+        public void Package_WithoutNupkgExtension_ShowsError()
+        {
+            FileInfo package = CreateTempFile(name: Path.ChangeExtension(Path.GetRandomFileName(), ".notpkg"));
+            var command = new ReleasifyCommand();
+
+            ParseResult parseResult = command.Parse($"--package \"{package.FullName}\"");
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.Package, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.StartsWith("--package does not have an .nupkg extension", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void Package_WithoutExistingFile_ShowsError()
+        {
+            string package = Path.ChangeExtension(Path.GetRandomFileName(), ".nupkg");
+            var command = new ReleasifyCommand();
+
+            ParseResult parseResult = command.Parse($"--package \"{package}\"");
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.Package, parseResult.Errors[0].SymbolResult?.Symbol.Parents.Single());
+            Assert.StartsWith($"File does not exist: '{package}'", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void BaseUrl_WithUrl_ParsesValue()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--baseUrl \"https://clowd.squirell.com\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal("https://clowd.squirell.com/", parseResult.GetValueForOption(command.BaseUrl)?.AbsoluteUri);
+        }
+
+        [Fact]
+        public void BaseUrl_WithNonHttpValue_ShowsError()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--baseUrl \"file://clowd.squirrel.com\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.BaseUrl, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.StartsWith("--baseUrl must contain a Uri with one of the following schems: http, https.", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void BaseUrl_WithRelativeUrl_ShowsError()
+        {
+            var command = new ReleasifyCommand();
+            string cli = GetRequiredDefaultOptions() + $"--baseUrl \"clowd.squirrel.com\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.BaseUrl, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.StartsWith("--baseUrl must contain an absolute Uri.", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void AddSearchPath_WithValue_ParsesValue()
+        {
+            string searchPath = CreateTempDirectory().FullName;
+            var command = new ReleasifyCommand();
+            string cli = GetRequiredDefaultOptions() + $"--addSearchPath \"{searchPath}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(searchPath, parseResult.GetValueForOption(command.AddSearchPath));
+        }
+
+        [Fact]
+        public void DebugSetupExe_WithFilePath_ParsesValue()
+        {
+            string debugExe = CreateTempFile().FullName;
+            var command = new ReleasifyCommand();
+            string cli = GetRequiredDefaultOptions() + $"--debugSetupExe \"{debugExe}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(debugExe, parseResult.GetValueForOption(command.DebugSetupExe)?.FullName);
+        }
+
+        [Fact]
+        public void NoDelta_BareOption_SetsFlag()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--noDelta";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.True(parseResult.GetValueForOption(command.NoDelta));
+        }
+
+        [Fact]
+        public void Runtime_WithValue_ParsesValue()
+        {
+            var command = new ReleasifyCommand();
+            string cli = GetRequiredDefaultOptions() + $"--framework \"net6,vcredist143\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal("net6,vcredist143", parseResult.GetValueForOption(command.Runtimes));
+        }
+
+        [Fact]
+        public void Icon_WithValidFile_ParsesValue()
+        {
+            FileInfo fileInfo = CreateTempFile(name: Path.ChangeExtension(Path.GetRandomFileName(), ".ico"));
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--icon \"{fileInfo.FullName}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(fileInfo.FullName, parseResult.GetValueForOption(command.Icon)?.FullName);
+        }
+
+        [Fact]
+        public void Icon_WithBadFileExtension_ShowsError()
+        {
+            FileInfo fileInfo = CreateTempFile(name: Path.ChangeExtension(Path.GetRandomFileName(), ".wrong"));
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--icon \"{fileInfo.FullName}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal("--icon does not have an .ico extension", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void Icon_WithoutFile_ShowsError()
+        {
+            string file = Path.GetFullPath(Path.ChangeExtension(Path.GetRandomFileName(), ".ico"));
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--icon \"{file}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.Icon, parseResult.Errors[0].SymbolResult?.Symbol.Parents.Single());
+            Assert.Contains(file, parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void SquirrelAwareExecutable_WithFileName_ParsesValue()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--mainExe \"MyApp.exe\"";
+            ParseResult parseResult = command.Parse(cli);
+            
+            Assert.Equal("MyApp.exe", parseResult.GetValueForOption(command.SquirrelAwareExecutable));
+        }
+
+        [Fact]
+        public void AppIcon_WithValidFile_ParsesValue()
+        {
+            FileInfo fileInfo = CreateTempFile(name: Path.ChangeExtension(Path.GetRandomFileName(), ".ico"));
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--appIcon \"{fileInfo.FullName}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(fileInfo.FullName, parseResult.GetValueForOption(command.AppIcon)?.FullName);
+        }
+
+        [Fact]
+        public void AppIcon_WithBadFileExtension_ShowsError()
+        {
+            FileInfo fileInfo = CreateTempFile(name: Path.ChangeExtension(Path.GetRandomFileName(), ".wrong"));
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--appIcon \"{fileInfo.FullName}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal($"--appIcon does not have an .ico extension", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void AppIcon_WithoutFile_ShowsError()
+        {
+            string file = Path.GetFullPath(Path.ChangeExtension(Path.GetRandomFileName(), ".ico"));
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--appIcon \"{file}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.AppIcon, parseResult.Errors[0].SymbolResult?.Symbol.Parents.Single());
+            Assert.Contains(file, parseResult.Errors[0].Message);
+        }
+
+        [WindowsOnlyTheory]
+        [InlineData(Bitness.x86)]
+        [InlineData(Bitness.x64)]
+        public void BuildMsi_WithBitness_ParsesValue(Bitness bitness)
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--msi \"{bitness}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(bitness, parseResult.GetValueForOption(command.BuildMsi));
+        }
+
+        [Fact]
+        public void SignTemplate_WithTemplate_ParsesValue()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--signTemplate \"signtool {{file}}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal("signtool {{file}}", parseResult.GetValueForOption(command.SignTemplate));
+        }
+
+        [Fact]
+        public void SignTemplate_WithoutFileParameter_ShowsError()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--signTemplate \"signtool file\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.SignTemplate, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.StartsWith("--signTemplate must contain '{{file}}'", parseResult.Errors[0].Message);
+        }
+
+        [WindowsOnlyFact]
+        public void SignParameters_WithParameters_ParsesValue()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--signParams \"param1 param2\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal("param1 param2", parseResult.GetValueForOption(command.SignParameters));
+        }
+
+        [WindowsOnlyFact]
+        public void SignParameters_WithSignTemplate_ShowsError()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--signTemplate \"signtool {{file}}\" --signParams \"param1 param2\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.StartsWith("Cannot use '--signParams' and '--signTemplate' options together", parseResult.Errors[0].Message);
+        }
+
+        [WindowsOnlyFact]
+        public void SignSkipDll_BareOption_SetsFlag()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--signSkipDll";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.True(parseResult.GetValueForOption(command.SignSkipDll));
+        }
+
+        [WindowsOnlyFact]
+        public void SignParallel_WithValue_SetsFlag()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + "--signParallel 42";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(42, parseResult.GetValueForOption(command.SignParallel));
+        }
+
+        [WindowsOnlyTheory]
+        [InlineData(-1)]
+        [InlineData(0)]
+        [InlineData(1001)]
+        public void SignParallel_WithBadNumericValue_ShowsError(int value)
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--signParallel {value}";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.SignParallel, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.Equal($"The value for --signParallel must be greater than 1 and less than 1000", parseResult.Errors[0].Message);
+        }
+
+        [WindowsOnlyFact]
+        public void SignParallel_WithNonNumericValue_ShowsError()
+        {
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--signParallel abc";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(1, parseResult.Errors.Count);
+            Assert.Equal(command.SignParallel, parseResult.Errors[0].SymbolResult?.Symbol);
+            Assert.Equal($"abc is not a valid integer for --signParallel", parseResult.Errors[0].Message);
+        }
+
+        [Fact]
+        public void ReleaseDirectory_WithDirectory_ParsesValue()
+        {
+            string releaseDirectory = CreateTempDirectory().FullName;
+            var command = new ReleasifyCommand();
+
+            string cli = GetRequiredDefaultOptions() + $"--releaseDir \"{releaseDirectory}\"";
+            ParseResult parseResult = command.Parse(cli);
+
+            Assert.Equal(releaseDirectory, parseResult.GetValueForOption(command.ReleaseDirectory)?.FullName);
+        }
+
+        private string GetRequiredDefaultOptions()
+        {
+            FileInfo package = CreateTempFile(name: Path.ChangeExtension(Path.GetRandomFileName(), ".nupkg"));
+
+            return $"-p \"{package.FullName}\" ";
+        }
+    }
+}