Fixing python test by waiting for Update.exe to finish

Fixed pathing issues on Windows pack tests
Adding pipeline logging for missing wix dll

.github/workflows/build-tests.yml

@@ -124,6 +124,8 @@ jobs:
           path: target/release
           pattern: rust-*
           merge-multiple: true
+      - name: List Binaries
+        run: ls target/release
       - name: Azure login
         uses: azure/login@v2
         if: github.event.pull_request.head.repo.full_name == github.repository

src/lib-python/test/run_test.py

@@ -102,6 +102,11 @@ _run_cmd(_pyinstaller_command)
 _run_cmd(["vpk", "pack", "--packId", "test-app", "--packVersion", "1.0.1", "--packDir", "dist/app/", "--mainExe", "app.exe"])
 # check if the app version is correct
 _run_cmd(["output/test-app.exe"])
+
+# Wait for update to complete
+log("Waiting for update to complete...")
+time.sleep(6)
+
 new_version = read_app_version("output/current/version_result.txt")
 if new_version.strip() != "1.0.1":
     raise RuntimeError(f"Version mismatch: expected '1.0.1' after update, got '{new_version.strip()}'")

test/Velopack.Packaging.Tests/WindowsPackTests.cs

@@ -302,7 +302,9 @@ public class WindowsPackTests
         // move package into local packages dir
         var fileName = $"{id}-2.0.0-full.nupkg";
         var mvFrom = Path.Combine(releaseDir, fileName);
-        var mvTo = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "velopack", id, "packages", fileName);
+        string packagesPath = GetPackagesPath(id);
+        Directory.CreateDirectory(packagesPath);
+        var mvTo = Path.Combine(packagesPath, fileName);
         File.Copy(mvFrom, mvTo, true);
 
         RunCoveredDotnet(appPath, ["--autoupdate"], installDir, logger, exitCode: null);
@@ -447,7 +449,10 @@ public class WindowsPackTests
         using var _1 = TempUtil.GetTempDirectory(out var releaseDir);
         using var _2 = TempUtil.GetTempDirectory(out var installDir);
         string id = "SquirrelIntegrationTest";
-        Directory.Delete(GetPackagesPath(id), true);
+        string packagesPath = GetPackagesPath(id);
+        if (Directory.Exists(packagesPath)) {
+            Directory.Delete(packagesPath, true);
+        }
 
         // pack v1
         await PackTestApp(id, "1.0.0", "version 1 test", releaseDir, logger);
@@ -721,7 +726,7 @@ public class WindowsPackTests
             PackDirectory = tmpOutput,
             Shortcuts = "Desktop,StartMenuRoot",
             BuildMsi = true,
-            MsiVersionOverride = "4.5.6.1"
+            MsiVersionOverride = "4.5.6.1 "
         };
 
         var runner = GetPackRunner(logger);