mirror of
https://github.com/velopack/velopack.git
synced 2025-10-25 15:19:22 +00:00
Merge pull request #1295 from pfeigl/fix_signtool_passwords
Strong passwords (anything except [a-zA-Z0-9_]) are now being obfuscated correctly for signtool calls
This commit is contained in:
@@ -596,7 +596,7 @@ namespace Squirrel.Update
|
||||
String.Format("sign {0} \"{1}\"", signingOpts, exePath), CancellationToken.None);
|
||||
|
||||
if (processResult.Item1 != 0) {
|
||||
var optsWithPasswordHidden = new Regex(@"/p\s+\w+").Replace(signingOpts, "/p ********");
|
||||
var optsWithPasswordHidden = new Regex(@"/p\s+\S+").Replace(signingOpts, "/p ********");
|
||||
var msg = String.Format("Failed to sign, command invoked was: '{0} sign {1} {2}'",
|
||||
exe, optsWithPasswordHidden, exePath);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user