Mirrors/velopack
1
0
Fork 0
mirror of https://github.com/velopack/velopack.git synced 2025-10-25 15:19:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix semver version check - 0.0.1 is now allowed with a release label

Browse Source
This commit is contained in:
Marco Franzen
2024-08-28 16:47:16 +02:00
committed by Caelan
parent 7394f01b51
commit 8fb1469e6e
3 changed files with 37 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib-csharp/NuGet/NugetUtil.cs
View File

@@ -41,7 +41,7 @@ namespace Velopack.NuGet
public static void ThrowIfVersionNotSemverCompliant(string version)
{
if (SemanticVersion.TryParse(version, out var parsed)) {
if (parsed < new SemanticVersion(0, 0, 1)) {
if (parsed < new SemanticVersion(0, 0, 1, parsed.Release)) {
throw new Exception($"Invalid package version '{version}', it must be >= 0.0.1.");
}
} else {

27
test/Velopack.Packaging.Tests/ReleasePackageTests.cs
View File

@@ -23,33 +23,6 @@
// {
// }
// [Theory]
// [InlineData("1.2.3")]
// [InlineData("1.2.3-alpha13")]
// [InlineData("1.2.3-alpha135")]
// [InlineData("0.0.1")]
// [InlineData("1.299656.3-alpha")]
// public void SemanticVersionParsesValidVersion(string ver)
// {
// NugetUtil.ThrowIfVersionNotSemverCompliant(ver);
// Assert.True(SemanticVersion.TryParse(ver, out var _));
// }
// [Theory]
// [InlineData("")]
// [InlineData("1")]
// [InlineData("0")]
// [InlineData("1.2.3.4")]
// [InlineData("1.2.3.4-alpha")]
// [InlineData("0.0.0.0")]
// [InlineData("0.0.0")]
// [InlineData("0.0")]
// [InlineData("0.0.0-alpha")]
// public void SemanticVersionThrowsInvalidVersion(string ver)
// {
// Assert.ThrowsAny<Exception>(() => NugetUtil.ThrowIfVersionNotSemverCompliant(ver));
// }
// [Fact]
// public void ReleasePackageIntegrationTest()
// {

36
test/Velopack.Tests/NugetUtilTests.cs Normal file
View File

@@ -0,0 +1,36 @@
using NuGet.Versioning;
using Velopack.NuGet;
namespace Velopack.Tests;
public class NugetUtilTests
{
[Theory]
[InlineData("1.2.3")]
[InlineData("1.2.3-alpha13")]
[InlineData("1.2.3-alpha135")]
[InlineData("0.0.1")]
[InlineData("0.0.1-beta")]
[InlineData("0.0.1-beta01")]
[InlineData("1.299656.3-alpha")]
public void SemanticVersionParsesValidVersion(string ver)
{
NugetUtil.ThrowIfVersionNotSemverCompliant(ver);
Assert.True(SemanticVersion.TryParse(ver, out var _));
}
[Theory]
[InlineData("")]
[InlineData("1")]
[InlineData("0")]
[InlineData("1.2.3.4")]
[InlineData("1.2.3.4-alpha")]
[InlineData("0.0.0.0")]
[InlineData("0.0.0")]
[InlineData("0.0")]
[InlineData("0.0.0-alpha")]
public void SemanticVersionThrowsInvalidVersion(string ver)
{
Assert.ThrowsAny<Exception>(() => NugetUtil.ThrowIfVersionNotSemverCompliant(ver));
}
}