mirror of
https://github.com/velopack/velopack.git
synced 2025-10-25 15:19:22 +00:00
Flow methods should not be virtual
This commit is contained in:
@@ -29,7 +29,7 @@ namespace Velopack.Sources
|
||||
public IFileDownloader Downloader { get; }
|
||||
|
||||
/// <inheritdoc />
|
||||
public async virtual Task<VelopackAssetFeed> GetReleaseFeed(ILogger logger, string channel, Guid? stagingId = null,
|
||||
public async Task<VelopackAssetFeed> GetReleaseFeed(ILogger logger, string channel, Guid? stagingId = null,
|
||||
VelopackAsset? latestLocalRelease = null)
|
||||
{
|
||||
Uri baseUri = new(BaseUri, $"v1.0/manifest/");
|
||||
@@ -65,7 +65,7 @@ namespace Velopack.Sources
|
||||
}
|
||||
|
||||
/// <inheritdoc />
|
||||
public async virtual Task DownloadReleaseEntry(ILogger logger, VelopackAsset releaseEntry, string localFile, Action<int> progress, CancellationToken cancelToken = default)
|
||||
public async Task DownloadReleaseEntry(ILogger logger, VelopackAsset releaseEntry, string localFile, Action<int> progress, CancellationToken cancelToken = default)
|
||||
{
|
||||
if (releaseEntry is null) throw new ArgumentNullException(nameof(releaseEntry));
|
||||
if (releaseEntry is not VelopackFlowReleaseAsset velopackRelease) {
|
||||
|
||||
Reference in New Issue
Block a user