Flow methods should not be virtual

This commit is contained in:
Caelan Sayler
2024-07-26 20:06:27 +01:00
parent 94ed3aee8a
commit e656c20084

View File

@@ -29,7 +29,7 @@ namespace Velopack.Sources
public IFileDownloader Downloader { get; } public IFileDownloader Downloader { get; }
/// <inheritdoc /> /// <inheritdoc />
public async virtual Task<VelopackAssetFeed> GetReleaseFeed(ILogger logger, string channel, Guid? stagingId = null, public async Task<VelopackAssetFeed> GetReleaseFeed(ILogger logger, string channel, Guid? stagingId = null,
VelopackAsset? latestLocalRelease = null) VelopackAsset? latestLocalRelease = null)
{ {
Uri baseUri = new(BaseUri, $"v1.0/manifest/"); Uri baseUri = new(BaseUri, $"v1.0/manifest/");
@@ -65,7 +65,7 @@ namespace Velopack.Sources
} }
/// <inheritdoc /> /// <inheritdoc />
public async virtual Task DownloadReleaseEntry(ILogger logger, VelopackAsset releaseEntry, string localFile, Action<int> progress, CancellationToken cancelToken = default) public async Task DownloadReleaseEntry(ILogger logger, VelopackAsset releaseEntry, string localFile, Action<int> progress, CancellationToken cancelToken = default)
{ {
if (releaseEntry is null) throw new ArgumentNullException(nameof(releaseEntry)); if (releaseEntry is null) throw new ArgumentNullException(nameof(releaseEntry));
if (releaseEntry is not VelopackFlowReleaseAsset velopackRelease) { if (releaseEntry is not VelopackFlowReleaseAsset velopackRelease) {